Skip to content

[media] Translate visits in media module#10548

Merged
driusan merged 4 commits into
aces:29.0-releasefrom
driusan:MoreMediaTranslate
Jul 23, 2026
Merged

[media] Translate visits in media module#10548
driusan merged 4 commits into
aces:29.0-releasefrom
driusan:MoreMediaTranslate

Conversation

@driusan

@driusan driusan commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Translates the visits in the media module.

@driusan driusan added the Multilingual Any tasks related to making LORIS multilingual label Jun 11, 2026
@github-actions github-actions Bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: media PR or issue related to media module labels Jun 11, 2026
@driusan
driusan changed the base branch from main to 29.0-release June 15, 2026 17:02
@CamilleBeau CamilleBeau added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jun 29, 2026
@driusan
driusan force-pushed the MoreMediaTranslate branch from 9b9f2d0 to 46ecbd9 Compare July 2, 2026 14:11
@driusan
driusan force-pushed the MoreMediaTranslate branch 2 times, most recently from 6daaf2d to 6fe499d Compare July 22, 2026 19:33
@driusan driusan mentioned this pull request Jul 22, 2026
Merged
driusan added a commit that referenced this pull request Jul 23, 2026
@driusan
[media] Translate Project in media and imaging_browser modules (#10988)
107d689 
Extracts the Project translation part of #10548 which did not cause test
failures into a different PR.
@driusan
driusan force-pushed the MoreMediaTranslate branch 2 times, most recently from 7cd0b5a to f1ecfb3 Compare July 23, 2026 16:40
@driusan driusan changed the title [media] Translate Projects, Visits in media module [media] Translate visits in media module Jul 23, 2026
@HachemJ HachemJ self-assigned this Jul 23, 2026
@HachemJ
HachemJ self-requested a review July 23, 2026 16:47
Dave MacFarlane added 2 commits July 23, 2026 14:27
Dave MacFarlane
Translate Projects, Visits in media module
456b738
Dave MacFarlane
Fix unit tests
a29be49 
The unit tests were failing because the test was mocking
pselect, so changing it to pselectCol changed the data.

Go back to the same structure for the tests sake.
@driusan
driusan force-pushed the MoreMediaTranslate branch from f1ecfb3 to a29be49 Compare July 23, 2026 18:28
HachemJ
HachemJ approved these changes Jul 23, 2026
View reviewed changes

@HachemJ HachemJ left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HachemJ HachemJ added the Passed manual tests PR has been successfully tested by at least one peer label Jul 23, 2026
@driusan
driusan merged commit 05f58c6 into aces:29.0-release Jul 23, 2026
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@HachemJ HachemJ HachemJ approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@driusan driusan

@HachemJ HachemJ

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: media PR or issue related to media module Multilingual Any tasks related to making LORIS multilingual Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@driusan @HachemJ @CamilleBeau